docs: update etcd-sync install and upgrade guidance#675
docs: update etcd-sync install and upgrade guidance#675
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 16 minutes and 42 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe etcd Synchronizer plugin installation and upgrade documentation is expanded to mandate a new Secret-based token configuration, add explicit cluster endpoint and VIP parameters, implement lease-holder-based leader detection, and refactor verification and resynchronization procedures. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
先不要合并，等待 etcd-sync 测试完成（包括 release-4.3) 合并这个之后，还需要往 release-4.3 去 cherry-pick |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/en/install/global_dr.mdx (1)
287-291: Routine Checkscurlnot updated for IPv6.The verification snippet at Line 194-203 was updated to use
curl -gwith bracketed IPv6 hosts, but the Routine Checks command here still uses the barecurl $(kubectl get svc ...)/checkform. In an IPv6 cluster this will produce an invalid URL for the same reason you fixed above. Consider updating it to match the new pattern for consistency.♻️ Suggested alignment
-```bash -curl $(kubectl get svc -n cpaas-system etcd-sync-monitor -o jsonpath='{.spec.clusterIP}')/check -``` +```bash +mirror_svc=$(kubectl get svc -n cpaas-system etcd-sync-monitor -o jsonpath='{.spec.clusterIP}') +ipv6_regex="^[0-9a-fA-F:]+$" +if [[ $mirror_svc =~ $ipv6_regex ]]; then + mirror_host="[$mirror_svc]" +else + mirror_host="$mirror_svc" +fi +curl -g "http://${mirror_host}/check" +```🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/en/install/global_dr.mdx` around lines 287 - 291, Update the Routine Checks curl snippet that calls kubectl get svc for etcd-sync-monitor so it handles IPv6 addresses like the earlier verification block: capture the service IP into a variable (e.g., mirror_svc), detect if it's an IPv6 address (regex match), wrap the host in brackets when IPv6 (mirror_host="[$mirror_svc]") and then call curl with -g and the bracketed host (curl -g "http://${mirror_host}/check"); replace the single-line curl $(kubectl ...) invocation with this guarded approach to match the earlier change and avoid invalid URLs on IPv6 clusters.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/en/install/global_dr.mdx`:
- Around line 287-291: Update the Routine Checks curl snippet that calls kubectl
get svc for etcd-sync-monitor so it handles IPv6 addresses like the earlier
verification block: capture the service IP into a variable (e.g., mirror_svc),
detect if it's an IPv6 address (regex match), wrap the host in brackets when
IPv6 (mirror_host="[$mirror_svc]") and then call curl with -g and the bracketed
host (curl -g "http://${mirror_host}/check"); replace the single-line curl
$(kubectl ...) invocation with this guarded approach to match the earlier change
and avoid invalid URLs on IPv6 clusters.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 12607ebc-b36e-4d4f-99ce-4cce9ec269f6
📒 Files selected for processing (2)
docs/en/install/global_dr.mdxdocs/en/upgrade/upgrade_global_cluster.mdx
Deploying alauda-container-platform with
|
| Latest commit: |
b2b9fc6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7483ff7a.alauda-container-platform.pages.dev |
| Branch Preview URL: | https://docs-etcd-sync-install-upgra.alauda-container-platform.pages.dev |
|
/lgtm |
2 participants
Summary
Testing
Summary by CodeRabbit