kube-ovn: update egress gateway document#685
kube-ovn: update egress gateway document#685zhangzujian wants to merge 1 commit intoalauda:masterfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 5 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR restructures and updates the Kube-OVN Egress Gateway configuration documentation, transitioning examples from macvlan-based to underlay-subnet/NAD naming conventions, reorganizing the content from Prerequisites/Usage into a numbered Before You Begin/Configuration Workflow format, adding a comparison table with centralized gateways, and consolidating operational guidance while removing parameter tables. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/en/configure/networking/how_to/kube_ovn/configure_egress_gateway.mdx (1)
489-541:⚠️ Potential issue | 🟡 MinorInconsistent VPC name between gateway2 spec and sample output.
The manifest on Line 496 sets
vpc: ovn-cluster, but the examplekubectl get vegoutput on Line 541 shows the VPC column asvpc1. Readers following the example will not seevpc1. Please align the two (either change the output toovn-cluster, or changespec.vpctovpc1— noting that the surroundinglr-policy-list ovn-clustercommands and LRP outputs on Lines 548–566 assume theovn-clusterVPC, so updating thekubectl get vegoutput is likely the correct fix).Also worth double-checking: the OVN address-set hash
$VEG.8ca38ae7da18on Lines 556–557 is identical to the one shown forgateway1on Lines 368–369. Since that identifier is derived from the gateway identity, it should differ betweengateway1andgateway2— please regenerate this sample output from an actualgateway2deployment.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/en/configure/networking/how_to/kube_ovn/configure_egress_gateway.mdx` around lines 489 - 541, The VPC name in the VpcEgressGateway manifest (metadata name: gateway2, spec.vpc: ovn-cluster) does not match the sample `kubectl get veg` output (VPC column shows vpc1) and the OVN address-set hash ($VEG.8ca38ae7da18) is duplicated from gateway1; update the sample output to use VPC "ovn-cluster" and regenerate the gateway2-specific OVN identifiers (address-set hash) so they differ from gateway1, ensuring consistency between the manifest (spec.vpc), the `kubectl get veg` output, and the downstream `lr-policy-list`/LRP outputs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@docs/en/configure/networking/how_to/kube_ovn/configure_egress_gateway.mdx`:
- Around line 489-541: The VPC name in the VpcEgressGateway manifest (metadata
name: gateway2, spec.vpc: ovn-cluster) does not match the sample `kubectl get
veg` output (VPC column shows vpc1) and the OVN address-set hash
($VEG.8ca38ae7da18) is duplicated from gateway1; update the sample output to use
VPC "ovn-cluster" and regenerate the gateway2-specific OVN identifiers
(address-set hash) so they differ from gateway1, ensuring consistency between
the manifest (spec.vpc), the `kubectl get veg` output, and the downstream
`lr-policy-list`/LRP outputs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 041b8d41-b092-4595-bec1-6dc805c2d30e
📒 Files selected for processing (1)
docs/en/configure/networking/how_to/kube_ovn/configure_egress_gateway.mdx
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Summary by CodeRabbit
Documentation