Skip to content

Return best inner solution#388

Open
alphaville wants to merge 6 commits intomasterfrom
feature/325-best-inner-solution
Open

Return best inner solution#388
alphaville wants to merge 6 commits intomasterfrom
feature/325-best-inner-solution

Conversation

@alphaville
Copy link
Owner

@alphaville alphaville commented Mar 16, 2026 •
edited
Loading

Main Changes

  • Return best PANOC half-step on early exit
  • Update GitHub PR template
  • Code optimisations: using cached values instead of recomputing

Associated Issues

Target versions

  • OpEn version 0.11.1

Checklist

  • All tests must pass
  • Update CHANGELOG(s)
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)

@alphaville
Return best PANOC half-step on early exit
a607677 
Issues:
- addresses #325

About:
- cache the feasible half-step with the lowest FPR seen so far
- return that cached point instead of the last half-step
- report the corresponding best FPR and recomputed cost
- add tests for best-half-step caching and premature termination
@alphaville
update PR tempalte
ab0b9f2
@alphaville alphaville self-assigned this Mar 16, 2026
@alphaville alphaville added enhancement New feature or request rust issue related to the code Rust library labels Mar 16, 2026
@alphaville alphaville changed the title Feature/325 best inner solution Return best inner solution Mar 16, 2026
@alphaville alphaville marked this pull request as ready for review March 16, 2026 17:24
@alphaville alphaville mentioned this pull request Mar 16, 2026
Draft
5 tasks
@alphaville
Code optimization: caching certain quantities
c731e32 
- cache gradient and projection-distance squared norms in PANOC
- derive squared FPR values inline from norm_gamma_fpr (already computed)
- update PANOC tests accordingly
@alphaville
Cargo-fmt + reuse cached PANOC cost during Lipschitz updates
63a7d37 
- remove the redundant  evaluation in
- add a unit test that counts cost function calls
@alphaville alphaville mentioned this pull request Mar 16, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@korken89 korken89 Awaiting requested review from korken89

@ruairimoran ruairimoran Awaiting requested review from ruairimoran

At least 1 approving review is required to merge this pull request.

Assignees

@alphaville alphaville

Labels

enhancement New feature or request rust issue related to the code Rust library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Always return best solution of inner problem

1 participant

@alphaville