Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Agent class to use a DBus object, introduces asynchronous input request handling via detached threads, and improves memory management and locking in the Manager class. Feedback identifies a critical use-after-free vulnerability in dispatch_method_call where a string is accessed after its parent variant is unreferenced, and highlights the risks of using detached threads without ensuring the lifetime of captured objects.
|
🧩 Build Artifacts ✅ The following build artifacts were produced: |
Store a pointer to dbus to finish the request input in the gdbus managed context. Spawn a thread that execute the request input callback so the user can block as long as he wants for user input. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
A lock is used to protect concurrent access to the services structure, once the service is found there is no need to continue locking the resource. The later allows to block the request input as long as the user want without locking the services and other members of the manager. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
Unref missing GPtrArray memory and add function to properly free field description structs. Signed-off-by: Eduardo Gonzalez <eduardo.gonzalez@amarulasolutions.com>
EddyTheCo
force-pushed
the
do_not_block_on_request_input
branch
from
c74f550 to
895478f
Compare
|
🧩 Build Artifacts ✅ The following build artifacts were produced: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.