Skip to content

AmdSmiPlugin update: xgmi check update #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandraBara merged 2 commits into from
Mar 16, 2026
+11 −26
Merged

AmdSmiPlugin update: xgmi check update #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b5708b
xgmi check update
alexandraBara Mar 13, 2026
18dc410
Merge branch 'development' into alex_amdsmi_fix
alexandraBara Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 11 additions & 26 deletions nodescraper/plugins/inband/amdsmi/amdsmi_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,6 @@ def check_expected_xgmi_link_speed(
)
return

expected_str = ", ".join(str(s) for s in expected_xgmi_speed)
mismatches: list[dict] = []

for xgmi_data in xgmi_metric:
link_metric = xgmi_data.link_metrics
try:
Expand All @@ -687,7 +684,7 @@ def check_expected_xgmi_link_speed(
continue

xgmi_float = float(link_metric.bit_rate.value)
except ValueError:
except (ValueError, TypeError):
self._log_event(
category=EventCategory.IO,
description="XGMI link speed is not a valid number",
Expand All @@ -701,31 +698,19 @@ def check_expected_xgmi_link_speed(
)
continue

if xgmi_float not in expected_xgmi_speed:
mismatches.append(
{
expected_floats = [float(e) for e in expected_xgmi_speed]
if xgmi_float not in expected_floats:
self._log_event(
category=EventCategory.IO,
description="XGMI link speed is not as expected",
priority=EventPriority.ERROR,
data={
"expected_xgmi_speed": expected_xgmi_speed,
"xgmi_bit_rate": xgmi_float,
"gpu": xgmi_data.gpu,
"actual_gt_s": xgmi_float,
"expected_gt_s": expected_str,
}
},
)

if mismatches:
details = "; ".join(
f"GPU {m['gpu']} {m['actual_gt_s']} GT/s (expected {m['expected_gt_s']})"
for m in mismatches
)
self._log_event(
category=EventCategory.IO,
description=f"XGMI link speed is not as expected: {details}",
priority=EventPriority.ERROR,
data={
"expected_gt_s": expected_str,
"mismatches": mismatches,
},
console_log=True,
)

def analyze_data(
self, data: AmdSmiDataModel, args: Optional[AmdSmiAnalyzerArgs] = None
) -> TaskResult:
Expand Down
Loading