Skip to content

fix: firebase FetchException wrapping and missing ADR doc #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirich1409 merged 1 commit into from
Apr 3, 2026
Merged

fix: firebase FetchException wrapping and missing ADR doc #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/guides/best-practices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ class CheckoutViewModel @Inject constructor(
}
```

See [ADR 001](../adr/001-configvalues-multi-module.md) for the rationale behind this design.

---

Expand Down
2 changes: 0 additions & 2 deletions mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,3 @@ nav:
- iOS Dead-Code Elimination: ios-integration.md
- API Reference: api/index.md
- Changelog: changelog.md
- ADRs:
- "ADR 001: ConfigValues Multi-Module": adr/001-configvalues-multi-module.md
2 changes: 0 additions & 2 deletions ...ase/src/main/kotlin/dev/androidbroadcast/featured/firebase/FirebaseConfigValueProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ public class FirebaseConfigValueProvider(

try {
task.await()
} catch (e: RuntimeException) {
throw e
} catch (e: Exception) {
throw FetchException("Firebase Remote Config fetch failed", e)
}
Comment on lines 99 to 103
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch() wraps all Exceptions from task.await() into FetchException. Since await() is cancellable, coroutine cancellation will throw CancellationException and should be rethrown (not wrapped), otherwise cancellation semantics are broken and callers may fail to cancel work properly. Add a catch (e: CancellationException) { throw e } before the generic catch (and import kotlinx.coroutines.CancellationException).

Copilot uses AI. Check for mistakes.
Expand Down
Loading