Skip to content

fix(@angular/build): only use external packages for polyfills when no local files are present #32761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clydin wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −5
Open

fix(@angular/build): only use external packages for polyfills when no local files are present #32761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions packages/angular/build/src/tools/esbuild/application-code-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,18 +654,19 @@ function getEsBuildCommonPolyfillsOptions(
tryToResolvePolyfillsAsRelative: boolean,
loadResultCache: LoadResultCache | undefined,
): BuildOptions | undefined {
const { jit, workspaceRoot, i18nOptions } = options;
const { jit, workspaceRoot, i18nOptions, externalPackages } = options;

let polyfills = options.polyfills ? [...options.polyfills] : [];

const buildOptions = getEsBuildCommonOptions({
...options,
externalPackages: false,
// If any polyfills are local files, disable external packages for the polyfills build.
// This ensures that local files are properly bundled.
externalPackages: polyfills.some(isLocalFile) ? false : externalPackages,
});
buildOptions.packages = 'bundle';
buildOptions.splitting = false;
buildOptions.plugins ??= [];

let polyfills = options.polyfills ? [...options.polyfills] : [];

// Angular JIT mode requires the runtime compiler
if (jit) {
polyfills.unshift('@angular/compiler');
Expand Down Expand Up @@ -749,3 +750,18 @@ function getEsBuildCommonPolyfillsOptions(
function entryFileToWorkspaceRelative(workspaceRoot: string, entryFile: string): string {
return './' + toPosixPath(relative(workspaceRoot, entryFile).replace(/.[mc]?ts$/, ''));
}

/**
* Determines if a polyfill path is a local file.
* A local file is defined as a path starting with a `.` or having a TypeScript/JavaScript extension.
* `zone.js` and its subpaths are specifically excluded and treated as packages.
* @param path The polyfill path to check.
* @returns true if the path is a local file; false otherwise.
*/
function isLocalFile(path: string): boolean {
if (path === 'zone.js' || path.startsWith('zone.js/')) {
return false;
}

return path.startsWith('.') || /\.[mc]?[jt]sx?$/.test(path);
}
Comment on lines +761 to +767
Copy link
Collaborator

@alan-agius4 alan-agius4 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:

Suggested change
function isLocalFile(path: string): boolean {
if (path === 'zone.js' || path.startsWith('zone.js/')) {
return false;
}
return path.startsWith('.') || /\.[mc]?[jt]sx?$/.test(path);
}
function isLocalFile(path: string): boolean {
if (path.startsWith('zone.js')) {
return false;
}
return path[0] === '.' || /\.[mc]?[jt]sx?$/.test(path);
}

Loading