Skip to content

ci: fix pnpm install and snapshot script for scheduled ci #33097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewseguin merged 1 commit into from
Apr 17, 2026
+7 −7
Merged

ci: fix pnpm install and snapshot script for scheduled ci #33097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/scheduled-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
# updates the lock file as expected with the changes
run: node ./scripts/circleci/setup-angular-snapshots.js main
- name: Install node modules
run: pnpm install
run: pnpm install --no-frozen-lockfile
- name: Run Browser tests
run: pnpm bazel test --build_tag_filters=-e2e --test_tag_filters=-e2e --build_tests_only -- src/...

Expand All @@ -51,7 +51,7 @@ jobs:
# updates the lock files as expected with the changes
run: node ./scripts/circleci/setup-angular-snapshots.js main
- name: Install node modules
run: pnpm install
run: pnpm install --no-frozen-lockfile
- name: Run linker tests using AOT
run: pnpm test-linker-aot
- name: Run linker tests using JIT
Expand Down
10 changes: 5 additions & 5 deletions scripts/circleci/setup-angular-snapshots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@ packagesToUpdate.forEach(({name, repoName}) => {

// Since the resolutions only cover the version of all nested installs, we also need
// to explicitly set the version for the package listed in the project "package.json".
packageJson.dependencies[name] = buildsUrl;

// In case this dependency was previously a dev dependency, just remove it because we
// re-added it as a normal dependency for simplicity.
delete packageJson.devDependencies[name];
if (packageJson.devDependencies && packageJson.devDependencies[name]) {
packageJson.devDependencies[name] = buildsUrl;
} else {
packageJson.dependencies[name] = buildsUrl;
}
});

// Write changes to the "packageJson", so that we can install the new versions afterwards.
Expand Down
Loading