Skip to content

ci: publish bazel rules snapshots#3514

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:snapshots
Mar 12, 2026
Merged

ci: publish bazel rules snapshots#3514
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:snapshots

Conversation

@alan-agius4
Copy link
Contributor

This commit integrates rules_angular, rules_browsers, and rules_sass into the repository's build and snapshot publishing workflow.

@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 12, 2026
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 12, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates rules_angular, rules_browsers, and rules_sass into the build and snapshot publishing process. The changes involve updating the release configuration, adding a new build script, and updating README files. The new build script tools/build-all.sh has a minor inefficiency where it calculates the git tree-ish inside a loop. I've suggested moving this calculation outside the loop to improve performance. The rest of the changes look good.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 12, 2026
This commit integrates rules_angular, rules_browsers, and rules_sass into the repository's build and snapshot publishing workflow.
},
{
name: 'rules_angular',
snapshotRepo: 'rules_angular',
Copy link
Contributor Author

@alan-agius4 alan-agius4 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the settings in these repos please to the same as the other snapshot repos?

IE: disallow PRs, disable issues, branch protection settings etc..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
{
name: 'rules_angular',
snapshotRepo: 'rules_angular',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alan-agius4 alan-agius4 removed the request for review from josephperrott March 12, 2026 15:29
@alan-agius4 alan-agius4 merged commit c0c287c into angular:main Mar 12, 2026
13 checks passed
@alan-agius4
Copy link
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the snapshots branch March 12, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants