Typings improvments

[aleek]

I added ConstraintTypes and Contraints definition. Nice to have, also I like the intellisense in VSC.

1. Tslint ran and all bugs fixed
2. unit tests run, 0 bugs.

Please review. If you like that, I'll add TypeScript Unit tests to jasmine.
Treat this as Work In Progress - please don't merge yet.

[coveralls]

Coverage remained the same at 100.0% when pulling d5a34a6 on aleek:typings into cccc345 on ansman:master.

[ElianCordoba]

Any updates on this?

[aleek]

@ElianCordoba what updates you'd like to see?

[ElianCordoba]

I just wanted to know the state of this PR, because i was thinking on doing it

[aleek]

Development is IMO currently done. Depends if someone thinks, I can improve something. Feel free to dev if you'd like.

[fugufish]

@aleek validate.options= for setting the default options is missing as well, I was going to add a PR but it seems more appropriate that it go here.

[drew-r]

I've had success with a mapped type for constraints.
e.g
validate<T>(attributes: T, constraints: Partial<{ [P in keyof T]: any }>)

[zepatrik]

Seems like @ansman won't merge it?

[grbspltt]

any chance of getting this PR merged?

[stramel]

Shouldn't constraints on single be of type ConstraintsTypes since it doesn't map to a key/name?

[stramel]

NIT: Could we make use of Record here? export type Constraints = Record<string, ConstraintsTypes>

[stramel]

Can you improve the return types on these? Maybe something like,
validate - Record<string, string[]> | undefined>
single - string[] | undefined
?

[sarangjo]

Any chance that this can be merged in? The any types are really frustrating to work with.

[zepatrik]

What about adding either this typing or #302's to @DefinitelyTyped ? Who would be up for a PR there @sarangjo @aleek @mauricedoepke ? I could do it but not now...

[sarangjo]

Will that override the typings provided by this repo?

[zepatrik]

Hm right, good point. After a quick search I would guess one could do a combination of microsoft/TypeScript#25495 and https://stackoverflow.com/questions/40322788/how-to-overwrite-incorrect-typescript-type-definition-installed-via-types-packa
Basically declaring the module in a @types package and using the following tsconfig.json

{
"compilerOptions": {
    "module": "validate.js",
    "noImplicitAny": true,
    "typeRoots": [
        "./node_modules/@types"
    ]
}
}

But this get's really hacky and will probably not be merged by @DefinitelyTyped

TL;DR the best way probably is to use one of the forks with the correct types as a dependency instead, as proposed in this thread: https://www.reddit.com/r/typescript/comments/cpe0u1/overriding_a_third_party_librarys_exported_types/

Maybe someone with more time can try what works...