Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Salvatore,
Thank you very much for the C course :)
This small PR fixes a missing
freecall for TFOBJ_TYPE_LIST, elements are freed in the loop but the list itself is not (this is handled correctly inlistPopType), and a crash in case of syntax error (compilemethod returnsNULL, which inmainwas passed toprintf).Moreover changes the while loop of
compilemethod to read the pointed value and not the pointer itself (which is never set toNULLand so the condition is always true), it is likely a typo (ref. lesson 2, minute 25).The program worked anyway because of the
breakstatement, which is still necessary because ofparseSpaces, though someone learning might be confused seeing that while condition.