feat(parquet): derive PartialEq and Eq for CdcOptions#9602
Open
kszucs wants to merge 1 commit intoapache:mainfrom
Open
feat(parquet): derive PartialEq and Eq for CdcOptions#9602kszucs wants to merge 1 commit intoapache:mainfrom
PartialEq and Eq for CdcOptions#9602kszucs wants to merge 1 commit intoapache:mainfrom
Conversation
CdcOptions only contains primitive fields (usize, usize, i32) so deriving PartialEq and Eq is straightforward. This is needed by downstream crates such as DataFusion that embed CdcOptions in their own configuration structs and need to compare them.
kszucs
changed the title
PartialEq and Eq for CdcOptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CdcOptions only contains primitive fields (usize, usize, i32) so deriving PartialEq and Eq is straightforward. This is needed by downstream crates such as DataFusion that embed CdcOptions in their own configuration structs and need to compare them.
What changes are included in this PR?
Implemented PartialEq and Eq for CdcOptions.
Are these changes tested?
Added an equality test.
Are there any user-facing changes?
No.