[CALCITE-7450] ValuesReduceRule incorrectly drops tuples when filter condition is irreducible#4846
Open
darpan-e6 wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-7450] ValuesReduceRule incorrectly drops tuples when filter condition is irreducible#4846darpan-e6 wants to merge 1 commit intoapache:mainfrom
darpan-e6 wants to merge 1 commit intoapache:mainfrom
Conversation
…condition is irreducible When the filter condition contains a UDF that cannot be reduced to a RexLiteral (e.g., no Janino CallImplementor), isAlwaysTrue() returns false for the unreduced RexCall, causing the rule to incorrectly drop the tuple. The fix checks whether the reduced value is a RexLiteral before evaluating isAlwaysTrue(); if it is not, the rule bails out and leaves the plan unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VALUEScontains a UDF with no JaninoCallImplementor,RexExecutorImplcannot reduce it to aRexLiteraland returns the expression unchanged.ValuesReduceRule.apply()then callsisAlwaysTrue()on the unreducedRexCall, which returnsfalse, causing the rule to incorrectly drop the tuple.RexLiteralbefore evaluatingisAlwaysTrue(); if it is not reducible, the rule bails out and leaves the plan unchanged.Test plan
ValuesReduceRuleTestwith a UDF (CUSTOM_FUNC) that cannot be reduced by Janino.PROJECT_FILTER_VALUES_MERGE— tuples are preserved.