Fixing CI failures by vishesh92 · Pull Request #12789 · apache/cloudstack

vishesh92 · 2026-03-11T12:11:18Z

Description

This PR fixes CI failures

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-03-11T12:21:15Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (7aa0558) to head (df72d04).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...storage/datastore/db/SnapshotDataStoreDaoImpl.java	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12789   +/-   ##
=========================================
  Coverage     17.61%   17.61%           
- Complexity    15664    15665    +1     
=========================================
  Files          5917     5917           
  Lines        531402   531402           
  Branches      64971    64971           
=========================================
  Hits          93596    93596           
  Misses       427252   427252           
  Partials      10554    10554

Flag	Coverage Δ
uitests	`3.70% <ø> (ø)`
unittests	`18.68% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2026-03-11T12:32:39Z

@blueorangutan package

blueorangutan · 2026-03-11T12:34:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-11T13:53:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17095

weizhouapache · 2026-03-11T13:55:16Z

great, only 1 CI failure now

vishesh92 · 2026-03-11T14:42:10Z

great, only 1 CI failure now

Looks it is intermittent. Let me push the fix to make it more reliable.

vishesh92 · 2026-03-11T14:43:04Z

@blueorangutan package

blueorangutan · 2026-03-11T14:44:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-11T15:52:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17100

weizhouapache · 2026-03-11T16:45:04Z

@blueorangutan test

blueorangutan · 2026-03-11T16:46:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland · 2026-03-11T18:42:10Z

@blueorangutan test matrix

blueorangutan · 2026-03-11T18:44:04Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

sureshanaparti

clgtm

blueorangutan · 2026-03-12T07:51:04Z

[SF] Trillian test result (tid-15610)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51304 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12789-t15610-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache

great
thanks @vishesh92 @sureshanaparti on the fix

do you know what caused it ?

vishesh92 · 2026-03-12T08:07:20Z

great thanks @vishesh92 @sureshanaparti on the fix

do you know what caused it ?

idStateNeqSearch was changed to idStateNinSearch in the below commit
6fdaf51#diff-105599d1a00be738da925c54fed738536e4d4b190b66947c0ab015d4605c7727R69

But this was reverted while forward merging
d700e2d#diff-105599d1a00be738da925c54fed738536e4d4b190b66947c0ab015d4605c7727R70

weizhouapache · 2026-03-12T08:39:19Z

great thanks @vishesh92 @sureshanaparti on the fix
do you know what caused it ?

idStateNeqSearch was changed to idStateNinSearch in the below commit 6fdaf51#diff-105599d1a00be738da925c54fed738536e4d4b190b66947c0ab015d4605c7727R69

But this was reverted while forward merging d700e2d#diff-105599d1a00be738da925c54fed738536e4d4b190b66947c0ab015d4605c7727R70

👍
thanks @vishesh92

blueorangutan · 2026-03-12T09:41:43Z

[SF] Trillian test result (tid-15614)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 51042 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12789-t15614-kvm-ubuntu22.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpn_usage	`Error`	1.09	test_usage.py

blueorangutan · 2026-03-12T11:08:03Z

[SF] Trillian test result (tid-15613)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55863 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12789-t15613-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2026-03-12T12:36:19Z

[SF] Trillian test result (tid-15615)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 61399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12789-t15615-vmware-70u3.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpn_usage	`Error`	1.11	test_usage.py

blueorangutan · 2026-03-12T15:15:36Z

[SF] Trillian test result (tid-15616)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 71555 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12789-t15616-xcpng82.zip
Smoke tests completed. 97 look OK, 52 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	189.84	test_events_resource.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_list_vms_metrics_admin	`Error`	0.12	test_metrics_api.py
test_list_vms_metrics_history	`Error`	0.12	test_metrics_api.py
test_list_vms_metrics_user	`Error`	0.14	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	0.13	test_metrics_api.py
test_nic_secondaryip_add_remove	`Failure`	0.07	test_multipleips_per_nic.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
ContextSuite context=TestNestedVirtualization>:setup	`Error`	0.00	test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup	`Error`	0.00	test_network_acl.py
test_01_verify_ipv6_network	`Failure`	1.55	test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	1206.12	test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	1206.18	test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	1416.36	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.35	test_network_permissions.py
test_delete_account	`Error`	3.30	test_network.py
test_delete_network_while_vm_on_it	`Error`	1.13	test_network.py
test_deploy_vm_l2network	`Error`	1.12	test_network.py
test_l2network_restart	`Error`	2.27	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	3.49	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	6.25	test_network.py
test_reboot_router	`Failure`	0.05	test_network.py
test_releaseIP	`Error`	3.33	test_network.py
test_releaseIP_using_IP	`Error`	3.24	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	3.30	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	1204.41	test_network.py
test_02_verifyRouterIpAfterNetworkRestart	`Failure`	603.79	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	1514.46	test_network.py
test_01_nic	`Error`	1557.72	test_nic.py
ContextSuite context=TestNonStrictAffinityGroups>:setup	`Error`	0.00	test_nonstrict_affinity_group.py
test_01_isolated_persistent_network	`Error`	603.07	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Error`	0.03	test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown	`Error`	0.07	test_persistent_network.py
ContextSuite context=TestPortForwardingRules>:setup	`Error`	0.00	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	0.23	test_primary_storage.py
test_01_primary_storage_iscsi	`Error`	306.80	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.22	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.41	test_primary_storage.py
ContextSuite context=TestPrivateGwACL>:setup	`Error`	0.00	test_privategw_acl.py
test_09_project_suspend	`Error`	1.07	test_projects.py
test_10_project_activation	`Error`	1.05	test_projects.py
ContextSuite context=TestPurgeExpungedVms>:setup	`Error`	0.00	test_purge_expunged_vms.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_network	`Error`	4.18	test_quarantined_ips.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_vpc	`Error`	0.27	test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_network	`Error`	0.25	test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_vpc	`Error`	0.28	test_quarantined_ips.py
test_deploy_vm_with_registered_userdata	`Error`	5.27	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	5.21	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	5.41	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny	`Error`	5.25	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	5.39	test_register_userdata.py
test_link_and_unlink_userdata_to_template	`Error`	5.31	test_register_userdata.py
test_user_userdata_crud	`Error`	5.35	test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_02_create_template_with_checksum_sha1	`Error`	65.50	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.43	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.46	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.45	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	7.39	test_templates.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestResourceNames>:setup	`Error`	0.00	test_resource_names.py
ContextSuite context=TestRestoreVM>:setup	`Error`	0.00	test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
test_1_userdata_on_ssvm	`Failure`	0.09	test_systemvm_userdata.py
test_2_userdata_on_cpvm	`Failure`	0.08	test_systemvm_userdata.py
test_3_userdata_on_vr	`Error`	5.41	test_systemvm_userdata.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
test_01_import_storage_policies	`Error`	0.00	test_storage_policy.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	0.15	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	0.14	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	1.28	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestScaleVm>:setup	`Error`	0.00	test_scale_vm.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.21	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestVmAutoScaling>:setup	`Error`	0.00	test_vm_autoscaling.py
ContextSuite context=TestSslOffloading>:setup	`Error`	0.00	test_ssl_offloading.py
test_01_list_sec_storage_vm	`Failure`	0.03	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.02	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.03	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.03	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.03	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.03	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.03	test_ssvm.py
test_08_reboot_cpvm	`Failure`	0.03	test_ssvm.py
test_09_reboot_ssvm_forced	`Failure`	0.03	test_ssvm.py
test_10_reboot_cpvm_forced	`Failure`	0.03	test_ssvm.py
test_11_destroy_ssvm	`Failure`	0.03	test_ssvm.py
test_12_destroy_cpvm	`Error`	1.12	test_ssvm.py
test_01_deploy_vm_on_specific_host	`Error`	0.07	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.22	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.27	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.10	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.26	test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	4.59	test_vm_life_cycle.py
ContextSuite context=TestVMSchedule>:setup	`Error`	0.00	test_vm_schedule.py
test_change_service_offering_for_vm_with_snapshots	`Error`	1.43	test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	13.74	test_vm_snapshots.py
ContextSuite context=TestMigrateVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py
test_01_register_vnf_template	`Error`	0.06	test_vnf_templates.py
test_02_list_vnf_template	`Error`	0.04	test_vnf_templates.py
test_03_edit_vnf_template	`Error`	0.04	test_vnf_templates.py
test_04_deploy_vnf_appliance	`Error`	0.05	test_vnf_templates.py
test_05_delete_vnf_template	`Error`	0.05	test_vnf_templates.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	4.44	test_volumes.py
test_01_verify_ipv6_vpc	`Error`	7.37	test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py

boring-cyborg bot added the component:storage label Mar 11, 2026

Fixing CI failures

f24ca6d

vishesh92 force-pushed the fix-ci-failures branch from f8d8477 to f24ca6d Compare March 11, 2026 12:11

fixup: test_secondary_storage

df72d04

boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Mar 11, 2026

sureshanaparti approved these changes Mar 12, 2026

View reviewed changes

sureshanaparti added the status:waiting-for-smoketest-results label Mar 12, 2026

sureshanaparti added this to Apache CloudStack 4.22.1 Mar 12, 2026

sureshanaparti added this to the 4.22.1 milestone Mar 12, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Mar 12, 2026

weizhouapache approved these changes Mar 12, 2026

View reviewed changes

sureshanaparti mentioned this pull request Mar 12, 2026

Fix snapshot chaining on Xen #12597

Open

14 tasks

DaanHoogland approved these changes Mar 12, 2026

View reviewed changes

vishesh92 mentioned this pull request Mar 13, 2026

Update bouncy castle #12794

Open

14 tasks

Conversation

vishesh92 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

weizhouapache commented Mar 11, 2026

Uh oh!

vishesh92 commented Mar 11, 2026

Uh oh!

vishesh92 commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

weizhouapache commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

DaanHoogland commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Mar 12, 2026

Uh oh!

weizhouapache commented Mar 12, 2026

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vishesh92 commented Mar 11, 2026 •

edited

Loading

codecov bot commented Mar 11, 2026 •

edited

Loading