Block backup deletion while create-VM-from-backup or restore jobs are in progress

[Damans227]

Description

Fixes: #11356

Adds a check in deleteBackup() to block deletion when a createVMFromBackup or restoreBackup async job is in progress for that backup.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Screen.Recording.2026-03-12.at.10.00.41.AM.mp4

How Has This Been Tested?

• Reproduced the problem: started createVMFromBackup, then attempted deleteBackup on same backup, confirmed it now throws CloudRuntimeException
• Added unit test testDeleteBackupBlockedByPendingJobs

How did you try to break this feature and the system with this change?

• Verified deleteBackup still succeeds when no pending jobs exist
• Verified existing unit tests work

[Damans227]

@blueorangutan package

[blueorangutan]

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.61%. Comparing base (7aa0558) to head (44f8036).
⚠️ Report is 5 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12792      +/-   ##
============================================
- Coverage     17.61%   17.61%   -0.01%     
  Complexity    15664    15664              
============================================
  Files          5917     5917              
  Lines        531402   531426      +24     
  Branches      64971    64974       +3     
============================================
+ Hits          93596    93599       +3     
- Misses       427252   427271      +19     
- Partials      10554    10556       +2     

Flag	Coverage Δ
uitests	3.70% <ø> (-0.01%)	⬇️
unittests	18.68% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

code lgtm

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17097

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17104

[sureshanaparti]

clgtm

[Copilot]

Pull request overview

This PR prevents VM backup deletion when there are in-progress async jobs that depend on the same backup (notably create-VM-from-backup and restore), avoiding failures caused by deleting a backup mid-operation.

Changes:

• Added a pending-async-job check to BackupManagerImpl.deleteBackup() to block deletion when related jobs are in progress.
• Added a unit test covering the “delete blocked by pending jobs” scenario.
• Updated existing test stubbing to include backup.getUuid() where required by the new logic.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java	Adds checkForPendingBackupJobs and calls it from deleteBackup to prevent deletion while dependent jobs are in progress.
server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java	Introduces a new unit test ensuring deletion is blocked when countPendingJobs(...) reports pending work.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.