Fix K8s scaling and deletion issue if firewall rule is for ALL ports#12806
Draft
Fix K8s scaling and deletion issue if firewall rule is for ALL ports#12806
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12806 +/- ##
============================================
- Coverage 16.25% 16.25% -0.01%
+ Complexity 13425 13424 -1
============================================
Files 5662 5662
Lines 500167 500169 +2
Branches 60740 60740
============================================
Hits 81318 81318
- Misses 409763 409765 +2
Partials 9086 9086
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
125
to
133
| // Remove existing SSH firewall rules | ||
| FirewallRule firewallRule = removeSshFirewallRule(publicIp); | ||
| int existingFirewallRuleSourcePortEnd; | ||
| if (firewallRule == null) { | ||
| throw new ManagementServerException("Firewall rule for node SSH access can't be provisioned"); | ||
| logger.warn("SSH firewall rule not found for Kubernetes cluster: {}. It may have been manually deleted or modified.", kubernetesCluster.getName()); | ||
| existingFirewallRuleSourcePortEnd = CLUSTER_NODES_DEFAULT_START_SSH_PORT + clusterVMIds.size() - 1; | ||
| } else { | ||
| existingFirewallRuleSourcePortEnd = firewallRule.getSourcePortEnd(); | ||
| } |
|
Member
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes: #11758
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?