Skip to content

test: run more JVM tests #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 3 commits into from
Apr 22, 2026
+4 −14
Merged

test: run more JVM tests #4026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48df253
test: run more Spark 4 tests
kazuyukitanimura Apr 22, 2026
d448f4c
test: run more JVM tests
kazuyukitanimura Apr 22, 2026
8be3a03
test: run more JVM tests
kazuyukitanimura Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2401,8 +2401,6 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}

test("get_struct_field - select primitive fields") {
val scanImpl = CometConf.COMET_NATIVE_SCAN_IMPL.get()
assume(!(scanImpl == CometConf.SCAN_AUTO && CometSparkSessionExtensions.isSpark40Plus))
withTempPath { dir =>
// create input file with Comet disabled
withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
Expand All @@ -2420,8 +2418,6 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}

test("get_struct_field - select subset of struct") {
val scanImpl = CometConf.COMET_NATIVE_SCAN_IMPL.get()
assume(!(scanImpl == CometConf.SCAN_AUTO && CometSparkSessionExtensions.isSpark40Plus))
withTempPath { dir =>
// create input file with Comet disabled
withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
Expand Down Expand Up @@ -2449,8 +2445,6 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}

test("get_struct_field - read entire struct") {
val scanImpl = CometConf.COMET_NATIVE_SCAN_IMPL.get()
assume(!(scanImpl == CometConf.SCAN_AUTO && CometSparkSessionExtensions.isSpark40Plus))
withTempPath { dir =>
// create input file with Comet disabled
withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
Expand Down
12 changes: 4 additions & 8 deletions spark/src/test/scala/org/apache/comet/CometMathExpressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ class CometMathExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelpe
DataGenOptions(generateNegativeZero = generateNegativeZero))
}

// https://github.com/apache/datafusion-comet/issues/3561
ignore("width_bucket") {
test("width_bucket") {
assume(isSpark35Plus, "width_bucket was added in Spark 3.5")
withSQLConf("spark.comet.exec.localTableScan.enabled" -> "true") {
spark
Expand All @@ -106,8 +105,7 @@ class CometMathExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelpe
}
}

// https://github.com/apache/datafusion-comet/issues/3561
ignore("width_bucket - edge cases") {
test("width_bucket - edge cases") {
assume(isSpark35Plus, "width_bucket was added in Spark 3.5")
withSQLConf("spark.comet.exec.localTableScan.enabled" -> "true") {
spark
Expand All @@ -124,8 +122,7 @@ class CometMathExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelpe
}
}

// https://github.com/apache/datafusion-comet/issues/3561
ignore("width_bucket - NaN values") {
test("width_bucket - NaN values") {
assume(isSpark35Plus, "width_bucket was added in Spark 3.5")
withSQLConf("spark.comet.exec.localTableScan.enabled" -> "true") {
spark
Expand All @@ -137,8 +134,7 @@ class CometMathExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelpe
}
}

// https://github.com/apache/datafusion-comet/issues/3561
ignore("width_bucket - with range data") {
test("width_bucket - with range data") {
assume(isSpark35Plus, "width_bucket was added in Spark 3.5")
withSQLConf("spark.comet.exec.localTableScan.enabled" -> "true") {
spark
Expand Down
Loading