Skip to content

Replace manual string truncation with apr_pstrndup to fix memory leak #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metsw24-max wants to merge 1 commit into
base: trunk
Choose a base branch
from
+5 −5
Open

Replace manual string truncation with apr_pstrndup to fix memory leak #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions server/config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,11 +634,11 @@ AP_DECLARE(const char *) ap_add_module(module *m, apr_pool_t *p,
*/

/* We cannot fix the string in-place, because it's const */
if (m->name[strlen(m->name)-1] == ')') {
char *tmp = ap_malloc(strlen(m->name)); /* FIXME: memory leak, albeit a small one */
memcpy(tmp, m->name, strlen(m->name)-1);
tmp[strlen(m->name)-1] = '\0';
m->name = tmp;
{
apr_size_t name_len = strlen(m->name);
if (name_len > 0 && m->name[name_len - 1] == ')') {
m->name = apr_pstrndup(p, m->name, name_len - 1);
}
}
#endif /*_OSD_POSIX*/

Expand Down