Merged
Conversation
kevinjqliu
approved these changes
Mar 12, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM thank you for the fix!
Comment on lines
+236
to
+239
| def test_pyarrow_timestamp_ns_no_tz_accepted() -> None: | ||
| pyarrow_type = pa.timestamp(unit="ns") | ||
| converted = visit_pyarrow(pyarrow_type, _ConvertToIceberg(format_version=3)) | ||
| assert converted == TimestampNanoType() |
Contributor
There was a problem hiding this comment.
pa.timestamp defaults tz to None
https://arrow.apache.org/docs/python/generated/pyarrow.timestamp.html
makes sense that it maps to TimestampNanoType
kris-gaudel
pushed a commit
to kris-gaudel/iceberg-python
that referenced
this pull request
Mar 13, 2026
Closes apache#3127 # Rationale for this change `pa.timestamp("ns", tz="US/Pacific") converts to TimestampNanoType()` (tz-naive) instead of raising `TypeError`. The `us` path correctly rejects non-UTC timezones. raises TypeError `visit_pyarrow(pa.timestamp("us", tz="US/Pacific"), _ConvertToIceberg())` silently drops timezone `visit_pyarrow(pa.timestamp("ns", tz="US/Pacific"), _ConvertToIceberg(format_version=3))` Fixes this by adding the correct elif clause ## Are these changes tested? Yes - added a couple of tests in the pyarrow visitor ## Are there any user-facing changes? It fixes the behavior that was a bug, so I think it would be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3127
Rationale for this change
pa.timestamp("ns", tz="US/Pacific") converts to TimestampNanoType()(tz-naive) instead of raisingTypeError. Theuspath correctly rejects non-UTC timezones.raises TypeError
visit_pyarrow(pa.timestamp("us", tz="US/Pacific"), _ConvertToIceberg())silently drops timezone
visit_pyarrow(pa.timestamp("ns", tz="US/Pacific"), _ConvertToIceberg(format_version=3))Fixes this by adding the correct elif clause
Are these changes tested?
Yes - added a couple of tests in the pyarrow visitor
Are there any user-facing changes?
It fixes the behavior that was a bug, so I think it would be.