Build: Stop ignoring gradle directory#15705
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Mar 20, 2026
Merged
Conversation
huaxingao
approved these changes
Mar 20, 2026
singhpk234
approved these changes
Mar 20, 2026
manuzhang
pushed a commit
to manuzhang/iceberg
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #15440, I noticed that changes under
gradle/, includinglibs.versions.toml, are ignored by git. We should not ignore this file because it is the source of truth for dependency versions and is already maintained in the project history: https://github.com/apache/iceberg/commits/main/gradle/libs.versions.tomlRemoving
gradle/from.gitignorealso makeslibs.versions.tomlshow up in VS Code search results, which improves discoverability when reviewing or updating dependencies.