ci: fix zizmor security alerts#15820
Merged
kevinjqliu merged 4 commits intoapache:mainfrom Mar 30, 2026
Merged
Conversation
kevinjqliu
commented
Mar 29, 2026
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@38697555549f1db7851b81482ff19f1fa5c4fedc # v4 | ||
| uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 # v4 |
Contributor
Author
There was a problem hiding this comment.
|
|
||
| - name: Run zizmor 🌈 | ||
| uses: zizmorcore/zizmor-action@71321a20a9ded102f6e9ce5718a2fcec2c4f70d8 # v0.5.2 | ||
| with: |
Contributor
Author
There was a problem hiding this comment.
by default, zizmor's advanced-security feature is on which will upload to the "security" tab, but wont error in CI.
We actually want the CI check to error, so we need to turn advanced-security off
stevenzwu
reviewed
Mar 30, 2026
| runs-on: ubuntu-latest | ||
| permissions: | ||
| security-events: write # Required for upload-sarif (used by zizmor-action) to upload SARIF files. | ||
| permissions: {} |
Contributor
There was a problem hiding this comment.
did we remove upload sarif?
Contributor
Author
There was a problem hiding this comment.
yes, see https://github.com/apache/iceberg/pull/15820/files#r3006745722
zizmor's default behavior is to not error in CI and report to the "security" tab via upload-sarif. We actually want zizmor to fail in CI during PR review so disabling its advanced-security feature
stevenzwu
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make zizmor error on CI failure
Fixes https://github.com/apache/iceberg/security/code-scanning
There was a timing issue which caused these to not be caught by zizmor ci (#15799 was merged after #15793)
Fix
github/codeql-action/initcommit hash and tag mismatchgradle/actions/setup-gradledisable alert, we want caching for CI. Default behavior is only write onmainbranch and read on PRs (https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#using-the-cache-read-only)