IGNITE-28036 Fix flaky IgniteOfflineBaselineNodeFullApiSelfTest#12843
IGNITE-28036 Fix flaky IgniteOfflineBaselineNodeFullApiSelfTest#12843abashev wants to merge 2 commits intoapache:masterfrom
Conversation
abashev
force-pushed
the
feature/IGNITE-28036
branch
from
6f3ce7a to
ddbe690
Compare
|
|
||
| if (delta <= 0) { | ||
| removeValue(); | ||
| cctx.shared().database().checkpointReadLock(); |
There was a problem hiding this comment.
- do we really need this lock ?
- can we cover with appropriate test such a case for defence in future ?
There was a problem hiding this comment.
Yes, we have that test - IgniteOfflineBaselineNodeFullApiSelfTest, it crashes all the time and this is a fix for it.
There was a problem hiding this comment.
Not sure such easy fix is a proper solution.
The question is why none of 16 cctx.shared().database().checkpointReadLock(); usages helped.
The solution is not to hold lock, but to understand why it's not held.
There was a problem hiding this comment.
The call starts from org.apache.ignite.internal.processors.cache.GridCacheAdapter.GlobalClearAllJob - this job is cleaning out expired objects from a cache and it starts without any locks with direct access to a cache. In any case it should add overall stability for all tests
There was a problem hiding this comment.
Still see no answer why none of 16 cctx.shared().database().checkpointReadLock(); usages helped.
|
3 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.