HDDS-14934. Enable BigIntegerInstantiation, ConsecutiveAppendsShouldReuse rule in PMD#10008
Draft
ptlrs wants to merge 2 commits intoapache:masterfrom
Draft
HDDS-14934. Enable BigIntegerInstantiation, ConsecutiveAppendsShouldReuse rule in PMD#10008ptlrs wants to merge 2 commits intoapache:masterfrom
ptlrs wants to merge 2 commits intoapache:masterfrom
Conversation
ptlrs
changed the title
adoroszlai
added
the
code-cleanup
Gargi-jais11
reviewed
Apr 1, 2026
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @ptlrs for the patch.
After you raised the PR there are many places which needs changes for .append chaining in DiskBalancerReportSubcommand. Please update this as well.
Rest LGTM.
adoroszlai
reviewed
Apr 1, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ptlrs for the patch. I would like to suggest splitting the change for BigIntegerInstantiation into a separate task. While there is only one exact violation, some other BigInteger creation can also be improved. Created HDDS-14955 for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enables new PMD rules:
BigIntegerandBigDecimalStringBuffer/StringBuilder.appendshould be chained, reusing the target object. This can improve the performance by producing a smaller bytecode, reducing overhead and improving inliningWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14934
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/23761982025