HDDS-14706. Make ozone admin om finalizeupgrade a no-op#10012
Draft
octachoron wants to merge 1 commit intoapache:HDDS-14496-zdufrom
Draft
HDDS-14706. Make ozone admin om finalizeupgrade a no-op#10012octachoron wants to merge 1 commit intoapache:HDDS-14496-zdufrom
octachoron wants to merge 1 commit intoapache:HDDS-14496-zdufrom
Conversation
Contributor
|
Is there more to do on this, or can it be moved from draft to ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ZDU will use one command to finalize the whole cluster with its own status flag. The OM server's endpoint to start finalization should therefore trivially return success for compatibility. This PR makes that change, and adjusts tests accordingly.
As this change leaves OMs without a way to start finalization until the new mechanism is implemented, some tests are temporarily marked as unhealthy:
ALREADY_FINALIZED. These checks would pass, and the finalization would not throw an error, but the actual snapshot-related tests would fail (as the finalization that enables the operations does not actually happen).How much not being able to trigger OM finalization blocks other work is unclear. Status could be reported as successful or not required (as outlined in https://issues.apache.org/jira/browse/HDDS-14707), but operations that depend on it would still fail the way they do in TestOmSnapshot.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14706
How was this patch tested?
CI on fork: https://github.com/octachoron/ozone/actions/runs/23847445751