HDDS-14922. Define invokeRatisServer or invokeRatisClient methods#10013
Open
Russole wants to merge 2 commits intoapache:masterfrom
Open
HDDS-14922. Define invokeRatisServer or invokeRatisClient methods#10013Russole wants to merge 2 commits intoapache:masterfrom
Russole wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Hi @szetszwo, could you please review this PR when you have time? Thank you! |
szetszwo
reviewed
Mar 31, 2026
Contributor
There was a problem hiding this comment.
@Russole , thanks for working on this! We should not use Proxy.newProxyInstance(..) anymore; see https://issues.apache.org/jira/secure/attachment/13081517/10013_review.patch
Comment on lines
+114
to
+117
| if (invoker != null) { | ||
| return invoker.invokeRatisServer( | ||
| method.getName(), method.getParameterTypes(), args); | ||
| } |
Contributor
There was a problem hiding this comment.
This change does not help since it is after the proxy. We should do it before the proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
invokeRatisServer(..)toScmInvokerto centralize Ratis server invocation logicSCMHAInvocationHandlertoScmInvokerSCMHAInvocationHandlerto delegateDIRECTinvocation toScmInvokerScmInvokeris not available (for backward compatibility)DeletedBlockLogStateManagerFollow-up
DeletedBlockLogStateManagerfirst; other SCM handlers will be updated in follow-up patchesWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14922
How was this patch tested?