HDDS-14795. Move the character length check to the server if the strict S3 naming flag is enabled#10014
Open
Russole wants to merge 4 commits intoapache:masterfrom
Open
HDDS-14795. Move the character length check to the server if the strict S3 naming flag is enabled#10014Russole wants to merge 4 commits intoapache:masterfrom
Russole wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Hi @sadanand48 , could you please review this PR when you have time? Thanks! |
Gargi-jais11
reviewed
Apr 1, 2026
Contributor
Gargi-jais11
left a comment
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @Russole for the patch. Overall LGTM.
Just few minor comments.
| @Test | ||
| public void preExecuteRejectsInvalidBucketName() { | ||
| // Verify invalid bucket name throws exception | ||
| public void preExecuteRejectsShortBucketNameWhenStrictS3Enabled() { |
Contributor
There was a problem hiding this comment.
Make this Parameterised and pass both bucket name less than 3 length and bucket name greater than 63 length, then check suck bucket names should be rejected.
| } | ||
|
|
||
| @Test | ||
| public void preExecuteAllowsShortBucketNameWhenStrictS3Disabled() |
Contributor
There was a problem hiding this comment.
Similarly, you can check if isS3strict=false then larger bucket name ( > 63) is allowed.
Contributor
Author
|
Thanks @Gargi-jais11 for the review. I've updated the test to a parameterized test and covered both cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14795
How was this patch tested?