[core] Add table properties sync to JDBC catalog#7423
Open
nickdelnano wants to merge 1 commit intoapache:masterfrom
Open
[core] Add table properties sync to JDBC catalog#7423nickdelnano wants to merge 1 commit intoapache:masterfrom
nickdelnano wants to merge 1 commit intoapache:masterfrom
Conversation
nickdelnano
commented
Mar 13, 2026
Comment on lines
+584
to
+601
| Map<String, String> properties = new HashMap<>(); | ||
| if (!tableSchema.primaryKeys().isEmpty()) { | ||
| properties.put( | ||
| CoreOptions.PRIMARY_KEY.key(), | ||
| String.join(",", tableSchema.primaryKeys())); | ||
| } | ||
| if (!tableSchema.partitionKeys().isEmpty()) { | ||
| properties.put( | ||
| CoreOptions.PARTITION.key(), | ||
| String.join(",", tableSchema.partitionKeys())); | ||
| } | ||
| if (!tableSchema.bucketKeys().isEmpty()) { | ||
| properties.put( | ||
| CoreOptions.BUCKET_KEY.key(), | ||
| String.join(",", tableSchema.bucketKeys())); | ||
| } | ||
| return properties; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
nickdelnano
force-pushed
the
nickdelnano/jdbc-table-properties
branch
2 times, most recently
from
7c97e03 to
448db52
Compare
nickdelnano
force-pushed
the
nickdelnano/jdbc-table-properties
branch
from
448db52 to
e6477c2
Compare
Contributor
Author
|
@JingsongLi can you review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #7421
Supporting table properties in JdbcCatalog similar to HiveCatalog support. Some implementation details are different due to differences in Hive vs Jdbc.
Table properties are stored in SQL table
paimon_table_propertiescontrolled by the existingsync-all-propertiesoption.Tests
Unit tests in JdbcCatalogTest. These use in memory sqlite database so they function like integration tests.
API and Format
N/A
Documentation
Updated docs
Generative AI tooling
Generated-by: claude code
I have reviewed the code.