Skip to content

RATIS-2493. Check actions with zizmor#103

Open
adoroszlai wants to merge 9 commits intoapache:masterfrom
adoroszlai:RATIS-2493
Open

RATIS-2493. Check actions with zizmor#103
adoroszlai wants to merge 9 commits intoapache:masterfrom
adoroszlai:RATIS-2493

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Validate GitHub Actions workflow with zizmor action
  • Fix violations
    • increase dependabot cooldown period
    • pin actions by SHA
    • do not persist credentials
    • restrict permissions
    • use secrets from apache org (see INFRA-27775 for details)
    • replace actions/cache with apache/infrastructure-actions/stash (see their README) to fix alleged cache-poisoning

https://issues.apache.org/jira/browse/RATIS-2493

How was this patch tested?

zizmor: https://github.com/adoroszlai/ratis-thirdparty/actions/runs/23915475636
CI: https://github.com/adoroszlai/ratis-thirdparty/actions/runs/23915475643

@adoroszlai adoroszlai self-assigned this Apr 2, 2026
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants