RATIS-2340. Add ReadIndexAsync executor for readIndex stateMachine query#1295
Open
symious wants to merge 1 commit intoapache:masterfrom
Open
RATIS-2340. Add ReadIndexAsync executor for readIndex stateMachine query#1295symious wants to merge 1 commit intoapache:masterfrom
symious wants to merge 1 commit intoapache:masterfrom
Conversation
szetszwo
reviewed
Oct 1, 2025
| return replyFuture | ||
| .thenCompose(readIndex -> getReadRequests().waitToAdvance(readIndex)) | ||
| .thenCompose(readIndex -> queryStateMachine(request)) | ||
| .thenComposeAsync(ignored -> stateMachine.query(request.getMessage()), readAsyncExecutor) |
Contributor
There was a problem hiding this comment.
@symious , Since it is calling stateMachine.query(..), the StateMachine implementation could choose to run it with its own executor. If we use an executor here, then the stateMachine has no choice and is forced to run it with Ratis executor. So I suggest not to make this change.
|
This PR has been marked as stale due to 60 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in ~30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the query work is done by the ELG worker threads, need to separate the works so that workers can focus on their job.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2340
How was this patch tested?
Stack dump shows not using ELG worker threads.