Skip to content

Check valid parent selection hash string #12985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serrislew merged 3 commits into from
Mar 25, 2026
Merged

Check valid parent selection hash string #12985

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e88052e
Check valid parent selection hash string
serrislew Mar 17, 2026
1ddcca1
add regression test
serrislew Mar 24, 2026
287ba18
off by one
serrislew Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/proxy/ParentSelection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "tscore/Regression.h"
#include "tscore/Tokenizer.h"

#include <string>
#include <string_view>

using namespace std::literals;
Expand Down Expand Up @@ -556,6 +557,11 @@ ParentRecord::ProcessParents(char *val, bool isPrimary)
errPtr = "Parent string is empty";
goto MERROR;
}
if (tmp3 && strlen(tmp3 + 1) > MAXDNAME) {
errPtr = "Parent hash string is too long";
goto MERROR;
}

// Update the pRecords
if (isPrimary) {
memcpy(this->parents[i].hostname, current, tmp - current);
Expand Down Expand Up @@ -1948,6 +1954,37 @@ EXCLUSIVE_REGRESSION_TEST(PARENTSELECTION)(RegressionTest * /* t ATS_UNUSED */,
FP;
RE(verify(result, ParentResultType::SPECIFIED, "minnie", 80), 213);

// Test 214
// Overlong hash_string (exceeding MAXDNAME chars) should be rejected by ProcessParents.
// The entry is discarded so findParent returns DIRECT.
{
tbl[0] = '\0';
ST(214);
std::string long_hash(MAXDNAME + 1, 'a');
std::string cfg = "dest_domain=. parent=host:80&" + long_hash + " round_robin=consistent_hash go_direct=true\n";
ink_strlcpy(tbl, cfg.c_str(), sizeof(tbl));
REBUILD;
REINIT;
br(request, "overlong.hash.net");
FP;
RE(verify(result, ParentResultType::DIRECT, nullptr, 0), 214);
}

// Test 215
// Max-length hash_string that fits (MAXDNAME chars) should be accepted.
{
tbl[0] = '\0';
ST(215);
std::string max_hash(MAXDNAME, 'b');
std::string cfg = "dest_domain=. parent=host:80&" + max_hash + " round_robin=consistent_hash go_direct=false\n";
ink_strlcpy(tbl, cfg.c_str(), sizeof(tbl));
REBUILD;
REINIT;
br(request, "maxlen.hash.net");
FP;
RE(verify(result, ParentResultType::SPECIFIED, "host", 80), 215);
}

delete request;
delete result;
delete params;
Expand Down