Skip to content

Add getter to check if registry is enabled #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulianVennen merged 3 commits into from
Mar 27, 2026
Merged

Add getter to check if registry is enabled #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b287eb
Add getter to check if registry is enabled
JulianVennen Mar 27, 2026
0f4a3b2
Apply copilot suggestions
JulianVennen Mar 27, 2026
56ee74a
Add test for en-/disabling registry
JulianVennen Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/GenericModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,16 @@ public static function enableRegistry(): void
static::$registry = true;
}

/**
* Check if the registry is enabled
*
* @return bool
*/
public static function isRegistryEnabled(): bool
{
return static::$registry;
}

/**
*
*
Expand Down
18 changes: 18 additions & 0 deletions test/tests/GenericModelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

namespace Aternos\Model\Test\Tests;

use Aternos\Model\GenericModel;
use PHPUnit\Framework\TestCase;

class GenericModelTest extends TestCase
{
public function testRegistry(): void
{
$this->assertTrue(GenericModel::isRegistryEnabled());
GenericModel::disableRegistry();
$this->assertFalse(GenericModel::isRegistryEnabled());
GenericModel::enableRegistry();
$this->assertTrue(GenericModel::isRegistryEnabled());
Comment on lines +12 to +16
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test assumes the registry is enabled at the start and also risks leaving the global static registry state modified if an assertion fails after disableRegistry(). Since other tests in the suite call disableRegistry() without re-enabling it (e.g., TestDriverTest::testUpdate()), this can make the test order-dependent/flaky. Consider capturing the initial state with GenericModel::isRegistryEnabled() and restoring it in a try/finally (or tearDown()), and avoid asserting a hard-coded initial true unless you explicitly set it first.

Suggested change
$this->assertTrue(GenericModel::isRegistryEnabled());
GenericModel::disableRegistry();
$this->assertFalse(GenericModel::isRegistryEnabled());
GenericModel::enableRegistry();
$this->assertTrue(GenericModel::isRegistryEnabled());
$initialState = GenericModel::isRegistryEnabled();
try {
// Ensure registry is enabled so we can test disabling and re-enabling it
if (!$initialState) {
GenericModel::enableRegistry();
}
$this->assertTrue(GenericModel::isRegistryEnabled());
GenericModel::disableRegistry();
$this->assertFalse(GenericModel::isRegistryEnabled());
GenericModel::enableRegistry();
$this->assertTrue(GenericModel::isRegistryEnabled());
} finally {
// Restore original registry state to avoid leaking global changes
if ($initialState !== GenericModel::isRegistryEnabled()) {
if ($initialState) {
GenericModel::enableRegistry();
} else {
GenericModel::disableRegistry();
}
}
}

Copilot uses AI. Check for mistakes.
}
}
Loading