fix(schema): add executionRoleArn to JSON schema#733
Closed
jesseturner21 wants to merge 1 commit intomainfrom
Closed
fix(schema): add executionRoleArn to JSON schema#733jesseturner21 wants to merge 1 commit intomainfrom
jesseturner21 wants to merge 1 commit intomainfrom
Conversation
The executionRoleArn field was added to the Zod schema in #729 but the JSON schema was not updated to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jesseturner21
temporarily deployed
to
e2e-testing
GitHub Actions
Inactive
jesseturner21
temporarily deployed
to
e2e-testing
GitHub Actions
Inactive
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-733-tarball/aws-agentcore-0.4.0.tgz |
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
executionRoleArnfield was added to the Zod schema (AgentEnvSpecSchema) in #729 but the JSON schema (agentcore.schema.v1.json) was not updated to match. This adds the missingexecutionRoleArnstring property to the JSON schema, placed betweenrequestHeaderAllowlistandauthorizerTypeto match the Zod schema order.Related Issue
Closes #729 (follow-up)
Type of Change
Testing
npm run test:unitandnpm run test:integnpm run typechecknpm run lintChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.