remove c rand from the standard retry strategy#3754
Open
Conversation
297b9aa to
3627e38
Compare
pulimsr
approved these changes
Mar 18, 2026
4ec4e17 to
7fcafee
Compare
DmitriyMusatkin
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Removes the usage of the c api "rand" from the standard retry strategy in favor of the c++ API random generator
std::mt19937. We refactor the thread local instance ofstd::mt19937used for pseudo random UUIDs to be used in both UUID and standard retry strategy.More importantly we remove the usage of
srandin the retry strategy constructor that lead to re-initialization of global state for rand each time the constructor was called.no tests were added as current coverage is sufficient enough
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.