fix: respect accept_eula in ModelBuilder LoRA deployment path#5696
Open
mollyheamazon wants to merge 1 commit intoaws:masterfrom
Open
fix: respect accept_eula in ModelBuilder LoRA deployment path#5696mollyheamazon wants to merge 1 commit intoaws:masterfrom
mollyheamazon wants to merge 1 commit intoaws:masterfrom
Conversation
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Introduced in commit
Description of changes:
The LoRA deployment path in
_build_single_modelbuilderhardcodedaccept_eula=Truein themodel_access_config, silently overriding whatever the user set on the ModelBuilder instance. This is inconsistent with the rest of the SDK — all finetuning classes (SFTTrainer, RLVRTrainer, DPOTrainer, RLAIFTrainer) went through the same fix in staging PR #1915.Changes:
self.accept_eulainstead of hardcoding Trueaccept_eulais not set to True, consistent with the finetuning classes patternBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.