Skip to content

Feature/session storage#32

Open
engine-turning wants to merge 2 commits intobaasbox:masterfrom
engine-turning:feature/session_storage
Open

Feature/session storage#32
engine-turning wants to merge 2 commits intobaasbox:masterfrom
engine-turning:feature/session_storage

Conversation

@engine-turning
Copy link
Copy Markdown

@engine-turning engine-turning commented Apr 27, 2015

The cookie previously contained sensitive user information which poses
a security risk.

Greg added 2 commits April 15, 2015 09:36
Disable Cookies
8802684 
Storing sensitive user information in a cookie is a security risk.
Removed sensitive information from cookie
5784f30 
The cookie previously contained sensitive user information which poses
a security risk.
@giastfader
Copy link
Copy Markdown
Member

giastfader commented Oct 25, 2015

Hi,
I see the potential problem, but in this way the semantic of getCurrentUser() is totally different. It no longer returns the current user with all their attribute but the session token.
getCurrentUser() should ask to the server the actual data instead of rely on cookies/local storage, and a new getSessionToken() should be implemented.
WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@engine-turning @giastfader