Use a nullable array implementation internally#2
Draft
craigfe wants to merge 3 commits intobacktracking:mainfrom
Draft
Use a nullable array implementation internally#2craigfe wants to merge 3 commits intobacktracking:mainfrom
craigfe wants to merge 3 commits intobacktracking:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the patch described in #1. It's not mergeable yet as it relies on extensions to
nullable-array(PRed here), but I thought I'd create the PR now in case there are any initial comments (which will perhaps create new requirements for my other patch).The changes are as follows:
~dummyarguments;resizeto require an initialisation element for the new suffix that it may create;shrink, a variant ofresizethat can only reduce the size of the vector and so doesn't need an initialisation element;nullable-arraylibrary.I haven't added any new test cases, but I'm very happy to do so. The existing ones are passing in the CI system on my own fork (here), which has decent platform coverage.