fix: remove broken prediction cache from WebLLM predictor#352
Merged
bartekplus merged 3 commits intomasterfrom Mar 25, 2026
Merged
fix: remove broken prediction cache from WebLLM predictor#352bartekplus merged 3 commits intomasterfrom
bartekplus merged 3 commits intomasterfrom
Conversation
The prediction cache (5s TTL, keyed by model+lang+input) was broken and provided negligible value. Remove PredictionCache class, all cache lookups/stores in WebLLMPredictor, related debug fields, and UI display. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove lastPrediction memoization cache from PresageHandler — same rationale as the WebLLM prediction cache removal. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Keep getLastPredictionInput() as a simple input tracker (not a cache) - Remove WebLLM cache test that tested deleted functionality - Update parallel test to expect presage called on every invocation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PredictionCacheclass and file entirelyWebLLMPredictor.predict()cacheSizefrom debug state, snapshot types, settings UI, and test fixturesTest plan
bun run checkpasses (lint, format, typecheck)bun run buildsucceeds🤖 Generated with Claude Code