Fix CI failures by updating OSError handling in test finalizers#477
Open
Harishmcw wants to merge 1 commit intobastibe:masterfrom
Open
Fix CI failures by updating OSError handling in test finalizers#477Harishmcw wants to merge 1 commit intobastibe:masterfrom
Harishmcw wants to merge 1 commit intobastibe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI failures on Windows builds.
The Problem
windows-2022but failing onwindows-latestbecause GitHub updated the latter to Windows Server 2025. On this newer image, closing an invalid file descriptor now fails silently instead of raising an OSError. Since the test strictly expected a crash via pytest.raises(OSError), the lack of an exception caused a test failure.The Soultion
tests/test_soundfile.pyto use atry/exceptblock. This ensures the file is closed if still open, but allows the test to pass if the OS handles the closure silently or if the library has already disposed of the resource.