Skip to content

chore: use term runfiles root instead of module space#3664

Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev:chore.sys.py.rename.module.space
Mar 15, 2026
Merged

chore: use term runfiles root instead of module space#3664
rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev:chore.sys.py.rename.module.space

Conversation

@rickeylev
Copy link
Collaborator

The term "module space" isn't very clear. The directory it refers to is the runfiles root
directory. So refer to it as that instead of "module space"

@rickeylev rickeylev requested a review from aignas as a code owner March 15, 2026 03:11
@rickeylev rickeylev enabled auto-merge March 15, 2026 03:11
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and consistency of terminology within the Python bootstrap scripts and related test infrastructure. By systematically replacing the ambiguous term 'module space' with the more precise 'runfiles root', the changes aim to make the codebase easier to understand and maintain. This refactoring includes updates to function signatures, variable names, environment variables, and corresponding test assertions, ensuring a unified vocabulary across relevant components.

Highlights

  • Terminology Refinement: The term 'module space' has been consistently replaced with 'runfiles root' across the codebase for improved clarity and accuracy.
  • Environment Variable Update: The environment variable RULES_PYTHON_TESTING_TELL_MODULE_SPACE has been renamed to RULES_PYTHON_TESTING_TELL_RUNFILES_ROOT to reflect the new terminology.
  • Code Refactoring: Function parameters, local variables, and comments related to the 'module space' concept have been updated to use 'runfiles root' or delete_runfiles_root.
  • Test Updates: Associated test files and scripts have been modified to align with the new terminology and environment variable names.
  • Configuration Cleanup: An outdated entry for examples/pip_repository_annotations was removed from .bazelrc.deleted_packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .bazelrc.deleted_packages
    • Removed an entry for examples/pip_repository_annotations.
  • python/private/python_bootstrap_template.txt
    • Renamed FindPythonBinary parameter module_space to runfiles_root.
    • Renamed FindBinary parameter module_space to runfiles_root.
    • Renamed FindModuleSpace function to find_runfiles_root.
    • Updated variable assignments and conditional checks from module_space to runfiles_root.
    • Updated delete_module_space variable and parameter to delete_runfiles_root.
    • Changed environment variable RULES_PYTHON_TESTING_TELL_MODULE_SPACE to RULES_PYTHON_TESTING_TELL_RUNFILES_ROOT.
  • python/private/stage1_bootstrap_template.sh
    • Updated the environment variable RULES_PYTHON_TESTING_TELL_MODULE_SPACE to RULES_PYTHON_TESTING_TELL_RUNFILES_ROOT.
  • tests/bootstrap_impls/bin_calls_bin/BUILD.bazel
    • Modified genrule commands to use RULES_PYTHON_TESTING_TELL_RUNFILES_ROOT instead of RULES_PYTHON_TESTING_TELL_MODULE_SPACE.
  • tests/bootstrap_impls/bin_calls_bin/inner.py
    • Updated the environment variable lookup from RULES_PYTHON_TESTING_TESTING_MODULE_SPACE to RULES_PYTHON_TESTING_RUNFILES_ROOT.
  • tests/bootstrap_impls/bin_calls_bin/outer.py
    • Updated the environment variable lookup from RULES_PYTHON_TESTING_TESTING_MODULE_SPACE to RULES_PYTHON_TESTING_RUNFILES_ROOT.
  • tests/bootstrap_impls/bin_calls_bin/verify.sh
    • Adjusted shell script variables and grep patterns to reflect the runfiles_root terminology.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@rickeylev rickeylev force-pushed the chore.sys.py.rename.module.space branch from 45d0ad6 to b3a0eb8 Compare March 15, 2026 03:13
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to clarify the codebase by renaming 'module space' to 'runfiles root'. The changes are mostly consistent, but I've found a few places where the old terminology or variable names persist, particularly in test files and a shell script template. I've also noted an opportunity to improve function naming consistency in one of the Python templates to align with PEP-8.

@rickeylev rickeylev added this pull request to the merge queue Mar 15, 2026
Merged via the queue into bazel-contrib:main with commit 73cad42 Mar 15, 2026
4 checks passed
@rickeylev rickeylev deleted the chore.sys.py.rename.module.space branch March 15, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants