feat: Make auto-links optional without removing other links#407
Open
mattpolzin wants to merge 4 commits intobeam-community:mainfrom
Open
feat: Make auto-links optional without removing other links#407mattpolzin wants to merge 4 commits intobeam-community:mainfrom
mattpolzin wants to merge 4 commits intobeam-community:mainfrom
Conversation
…nks to show up regardless.
…g links relate to each other
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the
remove_linksconfiguration to be less granular than needed in some cases. Specifically, if you want to be able to explicitly define some links but not also add the automatically generated links, you cannot do so:remove_links: false-> you get links added automaticallyremove_links: true-> you don't get your explicitly added linksWhat I decided is that a more useful take on the configuration might be to decide whether to add autogenerated links or not instead of deciding whether to remove all links or not. I did this with a new
add_auto_linksconfiguration.In this PR, I am careful to not break existing configurations by leaving the
remove_linksbehavior the same. I think that a future major release of this library could revisit these configuration options and come up with a more coherent singlelinksconfiguration but that's a discussion for another day.