Handle mouse history navigation when Now is selected#2455
Open
Ajeem-git wants to merge 1 commit intobit-team:devfrom
Open
Handle mouse history navigation when Now is selected#2455Ajeem-git wants to merge 1 commit intobit-team:devfrom
Ajeem-git wants to merge 1 commit intobit-team:devfrom
Conversation
Member
|
Hello Ajeem, thank you for your contribution and taking time to improve Back In Time. I appreciate it. On a quick initial review your PR looks good. I'll review it in detail later. Please note that currently I have to put all PRs on hold, because the Back In Time code base is in a transition phase. I am rewriting the mounting subsystem from scratch (PR #2449). Since the components are not well isolated, this affects nearly every file. To avoid complex merge conflicts, all other PRs are temporarily on hold. Best wishes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Prevent a crash when mouse back/forward navigation reaches directory history while Now is selected.
What changed:
Why:
Directory history navigation is snapshot-based. When Now is selected there is no backup context to resolve the stored path against, so the safest behavior is to ignore the navigation request.
Verification:
Note:
I could not fully reproduce the Qt GUI flow locally on macOS because the project expects Linux-oriented PyQt6 and dbus runtime dependencies.