Do not generate s500 since it conflicts with Ping1D Message definition#168
Do not generate s500 since it conflicts with Ping1D Message definition#168patrickelectric wants to merge 1 commit intobluerobotics:masterfrom
Conversation
patrickelectric
requested review from
ES-Alexander,
joaoantoniocardoso and
joaomariolago
Conflict with Ping1D definition of message for set speed of sound, where they use same id by different units Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
fix-ping
branch
from
1d1174a to
922a7e1
Compare
| definitions.PING360_DEVICE_DATA, | ||
| definitions.PING360_AUTO_DEVICE_DATA, | ||
| definitions.SURVEYOR240_ATOF_POINT_DATA, | ||
| definitions.SURVEYOR240_YZ_POINT_DATA, |
There was a problem hiding this comment.
was this removal intentional?
There was a problem hiding this comment.
Nops, thanks for noticing it!
ES-Alexander
left a comment
ES-Alexander
left a comment
There was a problem hiding this comment.
I don't like that we're removing library support for a publicly used message set, but I'm also not sure what the alternative is if it breaks the library / causes conflicts for use-cases that were established before that message set was added...
It may be preferable to allow message sets to overwrite/extend other messages, but if I'm understanding correctly there are issues with doing that currently, which makes this a necessary evil fix for an issue that will ideally have a better solution longer term.
Please do fix the point @joaoantoniocardoso raised before merging though.
3 participants
No description provided.