fix(macromap): correct return value in expand_predefined_macro#247
Open
Rac75116 wants to merge 2 commits intoboostorg:developfrom
Open
fix(macromap): correct return value in expand_predefined_macro#247Rac75116 wants to merge 2 commits intoboostorg:developfrom
Rac75116 wants to merge 2 commits intoboostorg:developfrom
Conversation
Collaborator
|
LGTM and thanks for your contribution; is there a rush on this? We are currently in the merge window - it could be possible to add it directly to master with permission from the release master, but I'd prefer to wait since we can't do the normal develop->master flow. |
Author
|
There’s no rush on this. I don't need the fix immediately, so I'm happy to wait for the normal develop->master flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #246