Skip to content

devenv: Deduplicate kani setup and devcontainer configs#145

Open
henrywang wants to merge 1 commit intobootc-dev:mainfrom
henrywang:enhancement
Open

devenv: Deduplicate kani setup and devcontainer configs#145
henrywang wants to merge 1 commit intobootc-dev:mainfrom
henrywang:enhancement

Conversation

@henrywang
Copy link
Contributor

Move gcc installation into install-kani.sh so the distro-specific package manager command isn't duplicated across all three Containerfiles. The script auto-detects dnf vs apt-get.

Add devcontainer-generate and devcontainer-validate recipes to generate per-OS devcontainer.json files from the default template and validate they stay in sync.

Assisted-by: Claude Code (Opus 4.6)

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the development environment setup by addressing two key areas: streamlining Kani's dependency installation and improving devcontainer configuration management. By moving gcc installation into a shared script, it eliminates duplication across different container images. Additionally, new just commands provide a robust mechanism to generate and validate OS-specific devcontainer configurations, ensuring consistency and ease of maintenance.

Highlights

  • Kani Setup Deduplication: Centralized the installation of gcc (a dependency for Kani) into the install-kani.sh script, removing redundant package manager commands from individual Containerfiles.
  • Devcontainer Configuration Management: Introduced new just recipes, devcontainer-generate and devcontainer-validate, to automate the generation and synchronization of per-OS devcontainer.json files from a single template, ensuring consistency across environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively deduplicates the gcc installation logic by centralizing it in install-kani.sh and introduces just recipes for managing devcontainer configurations, which improves maintainability. The changes are well-structured. I have a couple of suggestions to enhance the robustness and scripting style of the new additions.

@henrywang henrywang requested a review from cgwalters March 18, 2026 01:22
Move gcc installation into install-kani.sh so the distro-specific
package manager command isn't duplicated across all three Containerfiles.
The script auto-detects dnf vs apt-get.

Add devcontainer-generate and devcontainer-validate recipes to generate
per-OS devcontainer.json files from the default template and validate
they stay in sync.

Assisted-by: Claude Code (Opus 4.6)
Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants