Merging next into Grid Variable branch#3343
Merged
bendudson merged 566 commits intofield-variable-expressionfrom Mar 28, 2026
Merged
Merging next into Grid Variable branch#3343bendudson merged 566 commits intofield-variable-expressionfrom
bendudson merged 566 commits intofield-variable-expressionfrom
Conversation
…d-fixes Run `LaplacePetsc` tests with 3D metric + various fixes
Pull out common classes for FFT/DST transforms in some Laplacians
Bumps [ZedThree/clang-tidy-review](https://github.com/zedthree/clang-tidy-review) from 0.23.0 to 0.23.1. - [Release notes](https://github.com/zedthree/clang-tidy-review/releases) - [Changelog](https://github.com/ZedThree/clang-tidy-review/blob/master/CHANGELOG.md) - [Commits](ZedThree/clang-tidy-review@v0.23.0...v0.23.1) --- updated-dependencies: - dependency-name: ZedThree/clang-tidy-review dependency-version: 0.23.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [externalpackages/boutdata](https://github.com/boutproject/boutdata) from `962d5a5` to `0e06267`. - [Release notes](https://github.com/boutproject/boutdata/releases) - [Commits](boutproject/boutdata@962d5a5...0e06267) --- updated-dependencies: - dependency-name: externalpackages/boutdata dependency-version: 0e0626716f7fec01d318c427a96e596055540efe dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [externalpackages/googletest](https://github.com/google/googletest) from `9156d4c` to `73a63ea`. - [Release notes](https://github.com/google/googletest/releases) - [Commits](google/googletest@9156d4c...73a63ea) --- updated-dependencies: - dependency-name: externalpackages/googletest dependency-version: 73a63ea05dc8ca29ec1d2c1d66481dd0de1950f1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions/checkout-6 Bump actions/checkout from 5 to 6
…ctions/cache-5 Bump actions/cache from 4 to 5
…nalpackages/boutdata-0e06267 Bump externalpackages/boutdata from `962d5a5` to `0e06267`
…nalpackages/googletest-73a63ea Bump externalpackages/googletest from `9156d4c` to `73a63ea`
Add more tests for FCI operators
…edThree/clang-tidy-review-0.23.1 Bump ZedThree/clang-tidy-review from 0.23.0 to 0.23.1
Useful for templates
Allows to write code for Field3D, that also works for Field2D
enable openmp for sundials if it is enabled for BOUT++
Inherit applyParallelBoundary functions
For FCI we need to be able to access "random" data from the adjacent slices. If they are split in x-direction, this requires some tricky communication pattern. It can be used like this: ``` // Create object GlobalField3DAccess fci_comm(thismesh); // let it know what data points will be required: // where IndG3D is an index in the global field, which would be the // normal Ind3D if there would be only one proc. fci_comm.get(IndG3D(i, ny, nz)); // If all index have been added, the communication pattern will be // established. This has to be called by all processors in parallel fci_comm.setup() // Once the data for a given field is needed, it needs to be // communicated: GlobalField3DAccessInstance global_data = fci_comm.communicate(f3d); // and can be accessed like this BoutReal data = global_data[IndG3D(i, ny, nz)]; // ny and nz in the IndG3D are always optional. ```
If they are two instances of the same template, this allows to have an if in the inner loop that can be optimised out.
lower_bound takes into account the data is sorted
Consistent developer tooling; refactor formatting CI
This reverts commit c37f698. [skip ci]
Revert "Use annotations instead of comments for `clang-tidy-review`"
- Add `Field::field_type()` virtual method - Removes `Mesh::communicate(FieldPerp&)` overload
boutpp cleanup
Required for properly communicating `FieldPerp` with multiple Z processors when using PETSc
Add communicator for XZ planes
Communicate `FieldPerp` consistently with other Fields
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
Update `uv.lock`
Updates the requirements on [pygithub](https://github.com/pygithub/pygithub) to permit the latest version. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/main/doc/changes.rst) - [Commits](PyGithub/PyGithub@v2.8.0...v2.9.0) --- updated-dependencies: - dependency-name: pygithub dependency-version: 2.9.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…rox-eq-2.9 Update pygithub requirement from ~=2.8 to ~=2.9
Missing argument to exception, misc. headers.
Unit tests now include Y guard cells.
FieldFactory can create Fields when bout::mesh::global is non-null but the size of the mesh (LocalNx etc.) is not set, because FieldFactory is created inside BoutMesh::load() via Options.
Addressing clang-tidy comments and Clang compiler warnings (sprintf use).
Set field sizes in the same way, but get and check sizes on allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test merge