fix(activity-thread): Hide Modify option on comment if resolved#3439
fix(activity-thread): Hide Modify option on comment if resolved#3439shahzadaziz wants to merge 1 commit intobox:masterfrom
Conversation
| </MenuItem> | ||
| )} | ||
| {canEdit && ( | ||
| {canEdit && !isResolved && ( |
There was a problem hiding this comment.
Is it not possible to have a backend change for this? If canEdit is false if the status is resolved on the backend, then we wouldn't need this extra flag on the FE.
There was a problem hiding this comment.
Ya I have been looking into EUW endpoints and extending permissions to add isResolved to both top level comment and replies. That seems like a better place put these checks.
That work is currently blocked but we can disregard this PR if that is the direction we agree on.
There was a problem hiding this comment.
Yeah I agree with the direction of extending permissions. This will also prevent users from bypassing the ui and hitting the endpoint directly.
There was a problem hiding this comment.
On the back-end canEdit should already be checking resolution status for top level and replies. I would be curious why it isn't coming through.
There was a problem hiding this comment.
@shahzadaziz Before your changes, did the menu item to modify comment show up when the comment is resolved?
3 participants
No description provided.