Skip to content

chore: upgrade eslint, storybook, testing-library minor versions#4482

Closed
tjuanitas wants to merge 4 commits intomasterfrom
chore-upgrade-minor-versions
Closed

chore: upgrade eslint, storybook, testing-library minor versions#4482
tjuanitas wants to merge 4 commits intomasterfrom
chore-upgrade-minor-versions

Conversation

@tjuanitas
Copy link
Copy Markdown
Contributor

@tjuanitas tjuanitas commented Mar 24, 2026

Summary by CodeRabbit

  • Chores

    • Updated numerous development dependencies (testing, Storybook, linting, build/release tooling and libraries) and removed obsolete dev dependencies to keep tooling current and secure.
    • No changes to runtime behavior, public APIs, scripts, or exported entities.
  • Refactor

    • Internal service-worker and mock-server code cleaned up and improved (minor internal behavior-preserving changes and additional timing metadata) with no impact on end-user behavior.

@tjuanitas tjuanitas requested a review from a team as a code owner March 24, 2026 15:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0e928f90-145c-420f-bcd7-5f4d36b36d8f

📥 Commits

Reviewing files that changed from the base of the PR and between 946e9e5 and fa11fd9.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .storybook/public/mockServiceWorker.js
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

Walkthrough

Bumped many devDependencies and peerDependencies in package.json and updated Storybook/MSW-related assets; refactored the Storybook mock service worker to record request interception timestamps and thread that value through request handling and client messaging.

Changes

Cohort / File(s) Summary
Dependencies manifest
package.json
Massive devDependency and peerDependency version bumps and removals: removed @formatjs/intl-unified-numberformat and babel-core; upgraded Storybook packages, testing libraries (@testing-library/*), ESLint & plugins, lodash, webpack/webpack-dev-server, stylelint, semantic-release, and many other dev deps; peerDependencies mirrored many version updates. No script or public API changes.
Storybook MSW worker
.storybook/public/mockServiceWorker.js
Refactored service worker event handlers; updated MSW embedded worker version/checksum; changed fetch interception to capture requestInterceptedAt = Date.now() and pass it through handleRequest -> getResponse, and include interceptedAt in REQUEST messages sent to the client. Minor formatting and arrow-function refactors only.

Sequence Diagram(s)

sequenceDiagram
  participant Client as Client
  participant SW as Service Worker
  participant Server as Network/Server
  rect rgba(135,206,250,0.5)
    Client->>SW: Sends fetch request
    SW->>SW: compute requestInterceptedAt = Date.now()
    SW->>SW: handleRequest(event, requestId, requestInterceptedAt)
    SW->>Client: postMessage({ type: "REQUEST", requestId, interceptedAt: requestInterceptedAt })
  end
  rect rgba(144,238,144,0.5)
    SW->>Server: forward/perform network fetch (if needed)
    Server-->>SW: return response
    SW->>Client: postMessage({ type: "RESPONSE", requestId, status, body })
    SW-->>Client: respondWith(response)
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

ready-to-merge

Suggested reviewers

  • jpan-box
  • reneshen0328
  • greg-in-a-box

Poem

🐰 I patched the worker, ticked the time,
Hopped through deps to make them prime,
A timestamp threaded, neat and slim,
Storybook sings a brighter hymn,
Hop, bump, ship — a tidy rhyme ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No PR description was provided by the author, leaving the description completely empty. Add a comprehensive PR description explaining the purpose of the dependency upgrades, any breaking changes, and testing performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main changes: upgrading eslint, storybook, and testing-library packages as shown in package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore-upgrade-minor-versions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tjuanitas
Copy link
Copy Markdown
Contributor Author

closing in favor of: #4483

@tjuanitas tjuanitas closed this Mar 24, 2026
@tjuanitas tjuanitas deleted the chore-upgrade-minor-versions branch March 24, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant