Expands cluster commands to support create, update, delete#722
Open
Expands cluster commands to support create, update, delete#722
Conversation
Currently we only support _read_ actions in the CLI, but we can/should expand those so that all cluster actions can be performed. This adds: - `delete` - `create` - `update` We've also added tests for cluster commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we only support read actions in the CLI, but we can/should expand those so that all cluster actions can be performed.
This adds:
deletecreateupdateWe've also added tests for cluster commands.
Changes
Implemented commands for the following, using
go-buildkite;createupdatedeleteExpanded test coverage to account for the cluster command use.
Testing
go test ./...)go fmt ./...)Disclosures / Credits
AI was used for this; it generated the code based off of the existing commands available and a reference to
go-buildkite, as well as guidance in how we wish to use persistent flags, such as--cluster-uuid. I have reviewed the generated code.