Draft
Conversation
f6f8e13 to
59d79a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the CLI to store full OAuth sessions in the system keychain instead of only storing the access token, and to refresh access tokens automatically when a stored session is near expiry.
It also fixes custom REST endpoint handling during
bk auth login.go-buildkiteexpects the API base URL and appendsv2/...itself, so endpoints set to something likehttp://api.buildkite.localhost/v2were ending up as/v2/v2/....Changes
oauth.Sessionmodel and refresh token grant supportbk auth loginto persist the full session after the code exchangeBUILDKITE_REST_API_ENDPOINTwhen resolving the authorised organisation after loginBUILDKITE_REST_API_ENDPOINTvalues ending in/v2so they work correctly withgo-buildkite/v2endpoint normalisationVerification
go test ./internal/config ./cmd/auth ./pkg/oauthmise run lintbuildkite.localhosttestrefresh_tokenandexpires_at