no more wstd-aws crate: instead example shows upstreamed functionality#122
Merged
no more wstd-aws crate: instead example shows upstreamed functionality#122
Conversation
pchickey
force-pushed
the
pch/aws_is_upstreamed
branch
2 times, most recently
from
aecf216 to
527f3a2
Compare
pchickey
force-pushed
the
pch/aws_is_upstreamed
branch
from
527f3a2 to
946c9de
Compare
yoshuawuyts
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of the AWS Rust SDK releases of March 4, 2026,
aws-smithy-wasmprovides the functionality previously provided by thewstd-awscrate. See smithy-lang/smithy-rs#4498 for more information.Remove the
wstd-awscrate from this repository, and convert the existing example into an example that shows usingaws-smithy-wasm. Change the README to describe using upstream.The new example is in its own workspace, and depends on
wstdfrom crates.io instead of a path dependency, becauseaws-smithy-wasmhas a dependency onwstdfrom crates.io. This example will only be updated when substantive changes toaws-smithy-wasmand related happen upstream.This PR also upgrades the entire project's MSRV to 1.91.1, in part because the aws dependencies now have that MSRV, and in part because the only prior motivation for supporting an older MSRV was to keep compatibility with earlier aws sdks. The 1.91.1 Rust release fixes a major bug with wasm-ld on wasm targets, and so additionally upgrading the MSRV is defensive against using Rust 1.91.0, which will fail in a baffling way.
After we publish a new wstd release with this change, I will manually publish a final wstd-aws revision indicating it is deprecated and aws-smithy-wasm should be used instead.